remove nunjucks templating in experimental plugin themes #4933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 6, 2022
filfreire
approved these changes
Jul 7, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog(Breaking changes): We have removed nunjucks templating support from themes. If your custom theme makes use of these, check the examples in #4933
We have decided to remove nunjucks templating from themes because it is unnecessary and adds quite a lot of complexity to the theme system (and is ABSOLUTELY TRIVIAL to remove).
36c6d41(#4933) converts all the internal themes. As you can see, it's very very straightforward.40b2ef8(#4933) serves as a tool (which, I expect we'll use for plenty of other things) that can solve this issue by downloading all the existing themes in the community. I did this and found that there were two that were using this feature (both, equally trivial to undo), so I went ahead and made them PRs to migrate away:1e0faeb(#4933) then adds some functionality to alert people to this (and writes unit tests for it! 😄).569f507 and 9fa66b2 was from a self review: the function no longer needs to be async now that it's not calling nunjucks rendering, and now we don't need a specific type for it since it's gone.
Now, when the user adds a theme that has this problem, they'll see something like this:
