header.typ is not required #1192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Thanks for your contribution. Would you mind including a test to assert this behavior in |
Maybe we should make it too? better to be compliant with the spec. |
|
@sean-sageify happy to merge this once we have taken care of the previous two notes. |
|
Also, this should be opened against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue: #1191
Per RFC 7519: https://tools.ietf.org/html/rfc7519#section-5
Use of this Header Parameter is OPTIONAL.
Therefore, header.typ should only be validated if provided. In addition, the spec does not require the parameter to be all upper case "JWT", but that change was not made.