Fix/jwt errorhandling #1362
Merged
Fix/jwt errorhandling #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| -- Decode token to find out who the consumer is | ||
| local jwt, err = jwt_decoder:new(token) | ||
| if err then | ||
| -- TODO: is this an internal server error? the token is invalid/cannot be parsed so isn't this a user error to be reported? |
There was a problem hiding this comment.
@thibaultcha ^^
The possible errors originate here
They seem user errors to me, any specific reason they are set to fail with a 500?
There was a problem hiding this comment.
Yeah those are user errors indeed.
|
@thibaultcha both remarks updated |
|
|
||
| if self.params.algorithm == "HS256" and self.params.secret == nil then | ||
| return helpers.responses.send_HTTP_BAD_REQUEST("No mandatory 'secret'") | ||
| end |
There was a problem hiding this comment.
The API is not the right place to perform schema validation. Schema validation must be performed at the Model layer, aka in the schema.lua file.
…ix/jwt_errorhandling # Conflicts: # spec/03-plugins/jwt/02-api_spec.lua
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #1247, see also #1244.