fix(plugin) fixes a wrong constant for the request size limit plugin #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| local RequestSizeLimitingHandler = BasePlugin:extend() | ||
|
|
||
| RequestSizeLimitingHandler.PRIORITY = 950 | ||
|
|
||
| local function check_size(length, allowed_size, headers) | ||
| local allowed_bytes_size = allowed_size * 100000 | ||
| local allowed_bytes_size = allowed_size * 1000000 |
There was a problem hiding this comment.
I find it much more convenient and requiring less cognitive load (as well as much less error prone) to declare constants representing size (including MBs) like so:
local CONST_NAME = X * 10^6 -- here X being 1Then use CONST_NAME in the module's function.
There was a problem hiding this comment.
updated, including a linter fix to make ci run
| local stringy = require "stringy" | ||
| local strip = require("pl.stringx").strip | ||
|
|
||
| local MEGABYTE = 10^6 |
thibaultcha
force-pushed
the
fix/request-size
branch
from
d8b1619 to
c6545d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
constant for mb was 100.000 instead of 1.000.000 causing request to be rejected falsy.
Full changelog
Issues resolved
Fixes #1415