feat(plugin) Adds upstream_latency as an option to Statsd plugin #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @bivdub for PR, would you please squash with rebase to one commit? |
bivdub
force-pushed
the
plugins/statsd/add-upstream-latency
branch
from
a44ba2d to
a639640
Compare
|
Fixed, sorry about that. First PR on an open source project. |
|
@thefosk LGTM, can be merged once tests pass. I ll also update Datadog plugin. |
|
welcome to the club @bivdub! |
thibaultcha
added
the
pr/ready (but hold merge)
|
@shashiranjan84 do test pass locally? |
|
@thefosk I did not test locally. |
|
@thefosk ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds upstream_latency as an option for the statsd logging plugin.
Full changelog
*adds upstream_stream latency as an option for statsd, reading the value from message.latencies.proxy
*adds test for the new value