hotfix(dao) make 'run_migrations()' only return strings #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
force-pushed
the
hotfix/dao-migrations-errors
branch
from
e2880d9 to
3bd2356
Compare
Tieske
added
pr/ready (but hold merge)
|
lgtm |
… error (result is always nil in case of an error)
|
after checking out failed tests, updated the fix. |
Tieske
added
pr/status/needs review
and removed
pr/ready (but hold merge)
|
?? there are 2 commits in this PR, your initial one that failed, my fix on top of yours... What did I miss? |
|
Maybe me thinking I pushed the updated patch but actually didn't 😇
|
|
(Yay tests!) |
thibaultcha
added
pr/ready (but hold merge)
|
Manually sqashed to keep the proper fix and merged to both next and master as a hotfix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the error raising:
Which would occur when the connection to the datastore could not be opened from the CLI (migrations step).