fix(globalpatches) randomseed throws error when seeded in wrong context #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| elseif not seed then | ||
| if not seed then | ||
| if ngx.get_phase() ~= "init_worker" then | ||
| ngx.log(ngx.ERR, "math.randomseed() must be called in init_worker") |
There was a problem hiding this comment.
Should actually error('', 2)
thibaultcha
force-pushed
the
fix/randomseed-patch
branch
from
0292158 to
e610923
Compare
thibaultcha
changed the title
thibaultcha
force-pushed
the
fix/randomseed-patch
branch
from
e610923 to
3144e77
Compare
thibaultcha
added
pr/ready (but hold merge)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title says it all