Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(galileo) default 'body_Size' when 'log_bodies=true' but no body #1657

Merged
merged 1 commit into from
Sep 19, 2016
Merged

fix(galileo) default 'body_Size' when 'log_bodies=true' but no body #1657

merged 1 commit into from
Sep 19, 2016

Conversation

thibaultcha
Copy link
Member

Full changelog

  • update the code to fallback on a default value if those sizes are
    still unset, rather than doing that in an else
  • add request/response tests
  • correctly log at DEBUG level in the buffer

Fix #1656

@thibaultcha
fix(galileo) default 'body_Size' when 'log_bodies=true' but no body
fd17967 
* update the code to fallback on a default value if those sizes are
 still unset, rather than doing that in an `else`
* add request/response tests
* correctly log at `DEBUG` level in the buffer

Fix #1656
@thibaultcha thibaultcha added this to the 0.9.2 milestone Sep 19, 2016
@thibaultcha thibaultcha added pr/ready (but hold merge) No more concerns, but do not merge yet (probably a conflict of interest with another PR or release) and removed pr/status/needs review labels Sep 19, 2016
@thibaultcha thibaultcha merged commit ec308c8 into next Sep 19, 2016
@thibaultcha thibaultcha deleted the fix/galileo-bodies-logging branch September 19, 2016 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tieske Tieske Tieske approved these changes

Assignees
No one assigned
Labels
pr/ready (but hold merge) No more concerns, but do not merge yet (probably a conflict of interest with another PR or release)
Projects
None yet
Milestone
0.9.2
Development

Successfully merging this pull request may close these issues.
2 participants
@thibaultcha @Tieske