fix(cluster) quiet keepalive events #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
requested changes
Sep 20, 2016
| -- @treturn table res A table representing the insert row (with fields created during the insertion). | ||
| -- @treturn table err If an error occured, a table describing the issue. | ||
| function DAO:insert(tbl, options) | ||
| check_arg(tbl, 1, "table") | ||
| options = options or {} |
There was a problem hiding this comment.
Should be:
function DAO:insert(tbl, options)
options = options or {}
check_arg(tbl, 1, "table")
check_arg(options, 2, "table")| @@ -82,7 +82,7 @@ local function send_keepalive(premature) | |||
| ngx_log(ngx.ERR, tostring(err)) | |||
| elseif #nodes == 1 then | |||
| local node = nodes[1] | |||
| local _, err = singletons.dao.nodes:update(node, node, {ttl=singletons.configuration.cluster_ttl_on_failure}) | |||
| local _, err = singletons.dao.nodes:update(node, node, {ttl=singletons.configuration.cluster_ttl_on_failure, quiet = true}) | |||
There was a problem hiding this comment.
Could we avoid long lines? As per our codestyle, not exceeding 80 chars width is ideal:
local _, err = singletons.dao.nodes:update(node, node, {
ttl = singletons.configuration.cluster_ttl_on_failure,
quiet = true
})
thibaultcha
added
pr/changes requested
subnetmarco
force-pushed
the
fix/cluster
branch
from
33bb5db to
6d0317d
Compare
thibaultcha
added
pr/ready (but hold merge)
thibaultcha
approved these changes
Sep 20, 2016
|
two questions;
|
Not testable, at least none are written regarding events propagation (other than invalidation), and as we know they are extremely unreliable. Testing that an event was not propagated is even trickier.
Eventually. Before the end of the day if so, because |
|
Has been implemented in |
|
I was working on the tests |
thibaultcha
pushed a commit
that referenced
this pull request
Sep 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full changelog