task(rate-limiting) Allow connecting to non-zero Redis databases (#17… #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) - Fix connection pool management per API.
|
@diegoparrilla thank you - could you also implement the same changes to the response rate-limiting plugin? The changes would be very similar if not almost identical. |
…lugin Fixed wrong fault-tolerant behaviour when using Redis. Now when redis fails, Kong bypasses rate limiting without error 500 returned.
Merged
|
Closed with #1941. |
|
I don't see this change in 0.11.0 version. Why is this not included? And how could we utilise the redis pool without this change? |
|
This is included in 0.11.0: https://github.com/Mashape/kong/blob/0.11.0/kong/plugins/rate-limiting/schema.lua#L20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: new features are to be opened against next, hotfixes against master.
Summary
Rate limiting now supports non-zero redis database.
Keep alived Redis connections were not working. Now they work, increasing the performance of the service.
Full changelog
Issues resolved
Fix #1726