Fix retrieving oauth2 params from body #1853
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an issue when you supply a JSON request with an empty body to the OAuth2 plugin. As the body is deemed to be 'nil' the JSON decode function does not like this (as it expects a string) and throws. This commit short circuits the retrieval process if the request method is GET or HEAD (as these do not provide bodies), and in the event that no body is supplied in another request type it provides a default empty JSON object to satisfy the decode process.
|
Having issues setting up the |
|
see also #1773 |
|
This bug hits us too... |
|
Closed with #1915 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is an issue when you supply a JSON request with an empty body to the OAuth2 plugin.
As the body is deemed to be 'nil' the JSON decode function does not like this (as it expects a string) and throws.
Issues resolved
This commit short circuits the retrieval process if the request method is GET or HEAD (as these do not provide bodies), and in the event that no body is supplied in another request type it provides a default empty JSON object to satisfy the decode process.