Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kong.conf.default: clarify purpose of cluster_listen_rpc #1860

Merged
merged 1 commit into from
Dec 2, 2016

Conversation

jdmonin
Copy link
Contributor

@jdmonin jdmonin commented Nov 30, 2016

Summary

In kong.conf.default comments, clarify purpose of cluster_listen_rpc parameter.

Full changelog

  • kong.conf.default: clarify purpose of cluster_listen_rpc in comments

As a new kong user, I was unsure of the purpose of cluster_listen_rpc from reading the docs. After reading through the code, I'd like to submit this to make that clearer for other new users.

I'd also like to update the paragraph at https://getkong.org/docs/0.9.x/configuration/#clustering-section with the same text; I'm still looking into the best way to do so.

Thank you for taking the time to look at my request.

@thibaultcha
Copy link
Member

Thanks for this, I believe it makes sense. The getkong.org website is open-sourced at https://github.com/Mashape/getkong.org and you can submit a PR there :)

@thibaultcha thibaultcha added the pr/ready (but hold merge) No more concerns, but do not merge yet (probably a conflict of interest with another PR or release) label Nov 30, 2016
@thibaultcha
Copy link
Member

Disregard the test failure, the error was due to an issue in the test suite that is already fixed in the next branch.

@jdmonin
Copy link
Contributor Author

jdmonin commented Dec 1, 2016

Thank you! To update the site's 0.9.x config doc I created PR Kong/docs.konghq.com#294 .

@Tieske Tieske merged commit 711a39b into Kong:next Dec 2, 2016
@jdmonin
Copy link
Contributor Author

jdmonin commented Dec 2, 2016

Thank you again. Quick question: Will this comment update be part of future 0.9.x releases, or should I submit a followup PR against master?

@Tieske
Copy link
Member

Tieske commented Dec 2, 2016

@jdmonin master will only get hotfixes, and 0.9.x only bugfixes. I'd say this goes into next which means it will be released as 0.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/ready (but hold merge) No more concerns, but do not merge yet (probably a conflict of interest with another PR or release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants