fix(core) properly cache plugin db miss #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patch the global tcp.connect function to use the internal dns resolver
…migration process
…rs an empty table if nothing is specified instead of the previous `nil`. So if table length is 0, drop it and revert to defaults.
using postgres it won't start, complaining no options table was provided, yet the debug line shows it does. using cassandra the tcp override debug lines don't show --> cassandra bypasses those overrrides. How??
…cli-tcp-override
Fix/dns2 cli tcp override
…eature/upstreams2
…advanced ring-balancer.
…res only targets & upstreams
…ndra and postgres
…using uncessary db access
Tieske
added
the
pr/changes requested
Tieske
commented
Dec 22, 2016
| local plugin | ||
|
|
||
| before_each(function() | ||
| helpers.dao:truncate_tables() |
There was a problem hiding this comment.
@thibaultcha I had to insert the above truncation of the tables, or the tests would continue to give me an error that an entry already existed for hooks2.com below.
Did recently anything change here, as I was under the impression that the tables would automatically truncate upon starting/stopping kong in tests.
More odd; it only gave me the error hooks2.com, but not on hooks1.com.
any ideas?
This was referenced Dec 23, 2016
subnetmarco
added a commit
that referenced
this pull request
Jan 12, 2017
Tieske
pushed a commit
that referenced
this pull request
Jan 18, 2017
* hotfix(db-miss) porting #1914 fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In case multiple rows are returned for the lookup, but none matches, there would be no sentinel value for the db-miss inserted, causing excessive db access.
Note: build on top of the
feature/upstreams2branch as that already had a lot of changes in the hooks tests. So should be merged only after upstreams, hence tagged aspr/status/incomplete.Full changelog
Issues resolved
Fix #1841
Fix #1870