Correct the length of a year #2025
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A year was incorrectly assumed to have 360 days. This change assumes a year has 365 days.
thibaultcha
requested changes
Jan 27, 2017
There was a problem hiding this comment.
Hi,
Thanks for looking into this!
I believe this change should also be applied to the rate-limiting plugin, see https://github.com/Mashape/kong/blob/master/kong/plugins/rate-limiting/policies.lua#L20
Thanks for providing some detailed info in the body section. For the next time, please follow the instructed branches naming and commit message format as found in the CONTRIBUTING.md's Submitting a Pull Request section (we follow the Angular template). Linking to related GH issues in the commit log message is also a good practice to enforce. Example:
fix(rate-limiting) correct length of a year
A year was incorrectly assumed to have 360 days.
This change assumes a year has 365 days.
Fix #2021
|
Let's get this into 0.9.9 as well once completed @thefosk |
thibaultcha
added
the
pr/changes requested
|
Another fix was pushed to master with the requested updates. Will be in 0.9.9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A year was incorrectly assumed to have 360 days. This change assumes a year has 365 days.
Note: new features are to be opened against next, hotfixes against master.
Issues resolved
Fix #2021