Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(conf) lua_socket_pool_size property in kong.conf #2109

Merged
merged 1 commit into from
Feb 21, 2017
Merged

feat(conf) lua_socket_pool_size property in kong.conf #2109

merged 1 commit into from
Feb 21, 2017

Conversation

subnetmarco
Copy link
Member

Full changelog

  • Added lua_socket_pool_size property in configuration file.

thibaultcha
thibaultcha requested changes Feb 21, 2017
View reviewed changes
Copy link
Member

@thibaultcha thibaultcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a new entry in the Changelog for this feature + update the documentation, so let's add it now to not forget about it. Otherwise, good enough.

kong.conf.default Outdated
@@ -322,3 +322,7 @@

#lua_package_cpath = # Sets the Lua C module search path
# (LUA_CPATH).

#lua_socket_pool_size = 30 # Specifies the size limit for every cosocket
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line has a trailing whitespace, it's too bad

kong.conf.default Outdated
@@ -322,3 +322,7 @@

#lua_package_cpath = # Sets the Lua C module search path
# (LUA_CPATH).

#lua_socket_pool_size = 30 # Specifies the size limit for every cosocket
# connection pool associated with every remote
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one too

@subnetmarco
Copy link
Member Author

subnetmarco commented Feb 21, 2017 •
edited
Loading

CHANGELOG updated in a separate PR.

@subnetmarco
Copy link
Member Author

@thibaultcha updated.

@subnetmarco subnetmarco merged commit b66bcaf into release/0.10.0 Feb 21, 2017
@subnetmarco subnetmarco deleted the feat/configuration branch February 21, 2017 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibaultcha thibaultcha thibaultcha requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@subnetmarco @thibaultcha