fix(oauth2) dont try to hide credentials in a multipart req body #2176
+22
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0pr0ck5
force-pushed
the
fix/oauth2_multipart_hide_cred
branch
from
d841124 to
597a843
Compare
|
Failed test seems unrelated to this change. |
Tieske
reviewed
Mar 9, 2017
kong/plugins/oauth2/access.lua
Outdated
| if ngx.req.get_method() ~= "GET" then -- Remove from body | ||
| local content_type = req_get_headers()[CONTENT_TYPE] | ||
| local is_upload = content_type and | ||
| string_find(content_type:lower(), "multipart/form-data", 1, true) |
There was a problem hiding this comment.
no need for lower() here
Since the 0.6.9 release, all the header names in the Lua table returned are converted to the pure lower-case form by default, unless the raw argument is set to true (default to false).
p0pr0ck5
force-pushed
the
fix/oauth2_multipart_hide_cred
branch
2 times, most recently
from
7acf6b3 to
767944c
Compare
|
@Tieske able to take another look at this one? rebased on top of |
|
To be more protective, shouldn't |
p0pr0ck5
force-pushed
the
fix/oauth2_multipart_hide_cred
branch
from
767944c to
1dd16bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Don't try to remove credentials from request bodies when the request is a multipart upload. This prevents a thread abort when trying to index a non-existent table.
Full changelog
Issues resolved
Fix #1952