[feature] Admin API now supports form-encoded and json #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amazing! been waiting for this! good work! 👏 this will also make the documentation so much cleaner! |
thibaultcha
force-pushed
the
feat/admin-api-content-type
branch
2 times, most recently
from
f021278 to
beb9d4e
Compare
- `parse_params()` is a Lapis helper which parses form-encoded or
application/json parameters. If sending form-encoded, it will unnest
keys like `value.object=123` to `{value={object=123}}`
- fix a bug in the schema validation. If a filed had more than 1 rule,
it would only validate one of them.
- fix Lapis's parsing behaviour with params such as `?key[1]=val`
being parsed as `{["1"]="val"}`. it is now properly parsed as `{"val"}`
- http_client.lua's `put()` can now send form-encoded payloads, nothing wrong with
that
refactor: `render_list` leverages Lapis utils
fix a couple of bugs in Admin API + tests
- bonus: refactor http_client.lua for a +50% smaller file
We can know if there was an error parsing the JSON by testing for `self.json` after the parsing happened.
thibaultcha
force-pushed
the
feat/admin-api-content-type
branch
from
0497eea to
e9e56ea
Compare
|
@ahmadnassri @nijikokun who updates the doc? |
|
We'll do it when finished and merged |
thibaultcha
force-pushed
the
feat/admin-api-content-type
branch
from
4456850 to
fbd58c2
Compare
|
Okay, this PR also converts our current PUT to being PATCH (that's what it was) and support for real PUT: create like POST if doesn't exist, update if a full body is given, (that is with an |
thibaultcha
force-pushed
the
feat/admin-api-content-type
branch
from
fbd58c2 to
ef09381
Compare
thibaultcha
added a commit
that referenced
this pull request
May 18, 2015
[feature] Admin API now supports form-encoded and json
This was referenced May 19, 2015
19 tasks
ctranxuan
pushed a commit
to streamdataio/kong
that referenced
this pull request
Aug 25, 2015
[feature] Admin API now supports form-encoded and json
hutchic
added a commit
that referenced
this pull request
Jun 10, 2022
* fix(ci) de-dup the test Docker files * chore(variable) use the correct variable * chore(docker-kong) use master to build the test images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse_params()is a custom Lapis helper which parses form-encoded or application/json parameters. If sending form-encoded, it will un-nest keys likevalue.object=123to{value={object=123}}?key[1]=valbeing parsed as{["1"]="val"}. it is now properly parsed as{"val"}We can now query the Admin API with form-encoded params or a JSON body assuming the content type contains
application/json. Malformed JSON will return a 400.Most of the new LOCs are tests, otherwise the actual number of LOCs is considerably reduced.
Hold on before merging, this maybe needs a bit more testing but opening to allow discussion.