hotfix(router) allow url escaped uris #2377
Conversation
bungle
force-pushed
the
feat/allow-url-encoded-uris-2
branch
from
a8d64d3 to
1d85424
Compare
kong/core/router.lua
Outdated
| else | ||
| local s = find(uri, "?", 2, true) | ||
| if s then | ||
| uri = sub(uri, 1, s - 1) |
There was a problem hiding this comment.
We need to strip the uri prior to the find_api call. The reason is that as this stands now, we would greatly increase the risk of cache miss because the same URL path may have different querystring parameters, hence resulting in a different cache key.
There was a problem hiding this comment.
As a side note, it may be worth it to introduce unit tests that ensure the cache is hit when appropriate in the future. Part of a future improvement we can do to ensure the stability of such a critical component :)
There was a problem hiding this comment.
Uh, good catch indeed. Sorry for this screw up :-)
There was a problem hiding this comment.
The fix is done and pushed, I need to add the cache hit / miss tests still.
thibaultcha
added
pr/changes requested
thibaultcha
added
pr/status/please review
and removed
pr/changes requested
Change the router to use `ngx.var.request_uri` instead of the normalized `ngx.var.uri`. Makes proxying more transparent. Fixes #2366
bungle
force-pushed
the
feat/allow-url-encoded-uris-2
branch
from
7292b55 to
29f81cb
Compare
|
Merged with minor modifications, thanks! |
Summary
Change the router to use
ngx.var.request_uriinstead of the normalizedngx.var.uri. Makes proxying more transparent.Issues resolved
Fix #2366