fix(upstream) proper primary_key in kong schema #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0pr0ck5
force-pushed
the
fix/upstream-schema
branch
2 times, most recently
from
2b08ae9 to
72e5657
Compare
p0pr0ck5
changed the title
This uncovers the bug detailed in #2358. This commit does not fix this bug, it merely fixes the test behaviors to use both cassandra and postgres.
p0pr0ck5
force-pushed
the
fix/upstream-schema
branch
from
72e5657 to
88c7e14
Compare
thibaultcha
reviewed
Apr 25, 2017
| @@ -37,25 +38,26 @@ dao_helpers.for_each_dao(function(kong_config) | |||
| describe("Admin API", function() | |||
| local client | |||
| local config_db | |||
There was a problem hiding this comment.
I think this variable becomes unused now, and I am curious why the CI failed to catch that, if so.
There was a problem hiding this comment.
(was it unused? and if so, did the linter caught it locally?)
There was a problem hiding this comment.
It is unused, not sure why the linter didn't catch it. Didn't catch it locally either
There was a problem hiding this comment.
Ok... Good to know. WE might want to double-check the luacheck settings under the spec folder then... 🤔
Neither cassandra nor postgres' primary key values were a compound of id and name, so the kong schema's needn't be, either.
p0pr0ck5
force-pushed
the
fix/upstream-schema
branch
from
88c7e14 to
13167c3
Compare
thibaultcha
approved these changes
Apr 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DELETE against upstream objects is currently broken when using cassandra because the schema defines the primary key as
{id, name}but both postgres and cassandra schemas actually define their PK withid. this causes failures because cassandra tries to delete against a non PK column.Full changelog
Issues resolved
Fix #2358