feat(serf) optionally log Serf commands #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subnetmarco
force-pushed
the
feat/serf-log
branch
from
6859f62 to
ef24d5c
Compare
thibaultcha
reviewed
Apr 18, 2017
kong/serf.lua
Outdated
| @@ -35,6 +38,7 @@ function Serf:invoke_signal(signal, args, no_rpc, full_error) | |||
| end | |||
| local rpc = no_rpc and "" or "-rpc-addr="..self.config.cluster_listen_rpc | |||
| local cmd = string.format("%s %s %s %s", self.config.serf_path, signal, rpc, tostring(args)) | |||
| ngx_log(DEBUG, cmd) | |||
There was a problem hiding this comment.
I think we need some context here, aka prefix the command with some kind of a [serf] running command: prefix, as we do all around the place.
subnetmarco
force-pushed
the
feat/serf-log
branch
from
ef24d5c to
c64a5e2
Compare
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small patch that gives more visibility to the commands that are being executed by Serf.
Full changelog
DEBUGlog level