feat(log) add balancer tries and failure information #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
reviewed
Apr 21, 2017
kong/kong.lua
Outdated
| @@ -217,7 +217,12 @@ function Kong.balancer() | |||
| -- record failure data | |||
| addr.failures = addr.failures or {} | |||
| local state, code = get_last_failure() | |||
There was a problem hiding this comment.
move local state, code = get_last_failure() above addr.failures = addr.failures or {} it makes code more pleasing to read, :-).
kong/kong.lua
Outdated
| state = state, | ||
| code = code, | ||
| ip = addr.ip, | ||
| port = addr.port, |
There was a problem hiding this comment.
should we start aligning equal = signs?
| it("serializes the tries and failure information", function() | ||
| ngx.ctx.balancer_address.tries = 3 | ||
| ngx.ctx.balancer_address.failures = { | ||
| { state = "next", code = 502, ip = "127.0.0.1", port = 1234 }, |
There was a problem hiding this comment.
some alignment could make it easier to read here as well.
The number of tries will be logged in the basic serializer. If any retries occurred, then failure information will be added as well.
thibaultcha
reviewed
Apr 28, 2017
| @@ -31,6 +31,8 @@ | |||
| configured log target-url includes credentials. Thanks to | |||
| [Amir M. Saeid](https://github.com/amir) for the contribution. | |||
| [#2430](https://github.com/Mashape/kong/pull/2430) | |||
| - Logging retries and failure information. | |||
| [#2429](https://github.com/Mashape/kong/pull/2429). | |||
There was a problem hiding this comment.
This should have went into the below section already having a "logging plugins" mention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of tries will be logged in the basic serializer. If any retries occurred, then failure information will be added as well.