Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jwt-auth) return 401 unauthorized instead of 403 #2433

Merged
merged 1 commit into from
Apr 21, 2017
Merged

fix(jwt-auth) return 401 unauthorized instead of 403 #2433

merged 1 commit into from
Apr 21, 2017

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Apr 21, 2017

On invalid claims the JWT plugin returned 403 forbidden instead
of the 401 unauthorized.

fixes #2409

@Tieske
fix(jwt-auth) return 401 unauthorized instead of 403
04fd055 
On invalid claims the JWT plugin returned `403 forbidden` instead
of the `401 unauthorized`.

fixes #2409
@Tieske Tieske force-pushed the fix/jwt-response branch from 6451be2 to 04fd055 Compare April 21, 2017 13:51
@Tieske Tieske self-assigned this Apr 21, 2017
@Tieske Tieske added this to the 0.10.2 milestone Apr 21, 2017
bungle
bungle approved these changes Apr 21, 2017
View reviewed changes
Copy link
Member

@bungle bungle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tieske Tieske merged commit 35467cc into master Apr 21, 2017
@Tieske Tieske deleted the fix/jwt-response branch April 21, 2017 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bungle bungle bungle approved these changes

Assignees

@Tieske Tieske

Labels
None yet
Projects
None yet
Milestone
0.10.2
Development

Successfully merging this pull request may close these issues.

invalid verified claim (option) should throw 401 instead of 403
2 participants
@Tieske @bungle