fix(oauth2) remove unique constraint on client_secret #2447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
reviewed
May 1, 2017
| { | ||
| name = "2017-04-24-oauth2_client_secret_not_unique", | ||
| up = [[ | ||
| ALTER TABLE oauth2_credentials DROP CONSTRAINT oauth2_credentials_client_secret_key; |
There was a problem hiding this comment.
Should we have IF EXISTS here (I'm not sure, but it doesn't hurt)?
p0pr0ck5
force-pushed
the
fix/oauth2-client-secret-unique
branch
4 times, most recently
from
3d7ae27 to
53a5e97
Compare
p0pr0ck5
force-pushed
the
fix/oauth2-client-secret-unique
branch
from
53a5e97 to
2e2a366
Compare
|
@bungle the migration now includes the |
thibaultcha
approved these changes
May 4, 2017
thibaultcha
added
pr/ready (but hold merge)
|
crap, missed the |
|
No that's fine, I think we should have a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the unique constraint on client_secret in the oauth2_credentials table. There appears to be no need to hold this constraint; indeed, no other authentication plugins take this approach (apart from JWT, which builds logic around maintaining a unique key).
Full changelog
Issues resolved
Fix #1972