fix(certificates) return proper format for GET /certificates route #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subnetmarco
approved these changes
Apr 28, 2017
subnetmarco
added
pr/ready (but hold merge)
|
@thibaultcha i know you had reservations on merging this into |
p0pr0ck5
force-pushed
the
fix/certificates-get
branch
2 times, most recently
from
803af57 to
26f91b0
Compare
p0pr0ck5
force-pushed
the
fix/certificates-get
branch
from
26f91b0 to
cc8697d
Compare
|
@p0pr0ck5 It's indeed not aligned with the documentation, so as much as this might be considered a breaking change, I made up my mind and do think it should be merged as well :) Will include it in 0.10.2, thanks for the hotfix! 😉 |
|
Merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GET /certificateswas originally built with some custom logic for thecertificate<->snisobject relationship, and as such did not use the paginated set helper used by most GET routes. This commit updates the response object to resemble that of other retrieval functions (as well as match the return format specified in the documentation).Full changelog
Issues resolved
Fix #2462