feat(init) checking that core shared dictionaries exist #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subnetmarco
force-pushed
the
feat/init-shared-dicts
branch
from
8b58bad to
f438e3f
Compare
thibaultcha
requested changes
Apr 28, 2017
kong/kong.lua
Outdated
| -- Check shared dictionaries | ||
| for _, dict in ipairs(DICTS) do | ||
| if not ngx.shared[dict] then | ||
| error("cannot find shared dictionary: "..dict) |
There was a problem hiding this comment.
I think we should instruct the user how to fix this issue:
"missing shared dict in Nginx configuration, are you " ..
"using a custom template? Make sure the 'lua_shared_dict' " ..
dict .. " [SIZE];" directive is defined."
thibaultcha
added
pr/changes requested
subnetmarco
added
pr/status/please review
and removed
pr/changes requested
|
Merged to release/0.10.2 with a few edits. |
thibaultcha
pushed a commit
that referenced
this pull request
Apr 29, 2017
Signed-off-by: Thibault Charbonnier <thibaultcha@me.com> Applied with stronger test (more reliable in case of failure), style changes and error message changes for readability. From #2466
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2350.