Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core) handle native 400 response codes #2476

Merged
merged 1 commit into from May 2, 2017
Merged

feat(core) handle native 400 response codes #2476

merged 1 commit into from May 2, 2017

Conversation

p0pr0ck5
Copy link
Contributor

@p0pr0ck5 p0pr0ck5 commented May 1, 2017

Summary

In addition to BAD_REQUEST messages sent by Kong, we should also
handle natively-generated 400 response codes.

Full changelog

  • handle native 400 response codes

Issues resolved

Fix #1816, #2085

@bungle
Copy link
Member

bungle commented May 1, 2017

In addition to BAD_REQUEST messages sent by Kong, we should also
handle natively-generated 400 response codes.
@p0pr0ck5
Copy link
Contributor Author

p0pr0ck5 commented May 1, 2017

@bungle sure, yeah we should keep these in sync. Updated.

@bungle bungle self-requested a review May 1, 2017 19:51
Copy link
Member

@bungle bungle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This is for next, so while it could break some code that is relying on the output (not a good thing to be honest), and I couldn't think anything else that this could break. So approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants