perf(rate-limiting) only increment configured limits #2488
Merged
+80
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subnetmarco
changed the title
p0pr0ck5
previously requested changes
May 3, 2017
p0pr0ck5
added
pr/changes requested
p0pr0ck5
added
pr/status/please review
and removed
pr/changes requested
|
LGTM, but this is missing context (the commit message explains what is happening, but now why- is this a perf improvement? Bug fix? Behavior change?). Would like to have a second pair of eyes as well, but seems clean. |
|
@p0pr0ck5 perf improvement, squashed and updated message |
subnetmarco
force-pushed
the
fix/rate-limiting-increments
branch
from
c4b11c0 to
156131b
Compare
subnetmarco
force-pushed
the
fix/rate-limiting-increments
branch
from
156131b to
705196c
Compare
thibaultcha
requested changes
May 12, 2017
thibaultcha
added
pr/changes requested
|
@thibaultcha as noted in the original PR summary, that deserves a different PR, also because response rate-limiting also has deeper problems in its test suite (currently not working). |
p0pr0ck5
approved these changes
May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes: the same patch will have to be applied to the Response Rate Limiting plugin in a separate PR.