New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(auth) handle nil anonymous consumers #2508

Merged
merged 1 commit into from May 11, 2017

Conversation

Projects
None yet
3 participants
@thefosk
Member

thefosk commented May 9, 2017

Summary

This PR deals with an error caused by the missing migrations file (fixed in #2313) without implementing the missing migration.

It prevents returning a 500 error on an invalid credential when conf.anonymous=nil.

This can be merged as a hotfix so it can land in a minor release, and reverted back in the next major since #2313 already takes care of it.

Full changelog

  • Fixes a bug that triggered 500 errors when an invalid credential is being sent.

@thefosk thefosk requested a review from Tieske May 9, 2017

@p0pr0ck5

lgtm; would like another pair of eyes as this touches master. @Tieske?

@Tieske

Tieske approved these changes May 10, 2017

@Tieske

This comment has been minimized.

Show comment
Hide comment
@Tieske

Tieske May 10, 2017

Member

@thefosk please do open an issue to keep track of reverting this.

Member

Tieske commented May 10, 2017

@thefosk please do open an issue to keep track of reverting this.

@thefosk thefosk merged commit af43508 into master May 11, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@thefosk thefosk deleted the hotfix/anonymous branch May 11, 2017

@thefosk thefosk referenced this pull request May 11, 2017

Closed

Revert #2508 on 0.11 #2515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment