Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(auth) handle nil anonymous consumers #2508

Merged
merged 1 commit into from May 11, 2017
Merged

Conversation

subnetmarco
Copy link
Member

@subnetmarco subnetmarco commented May 9, 2017

Summary

This PR deals with an error caused by the missing migrations file (fixed in #2313) without implementing the missing migration.

It prevents returning a 500 error on an invalid credential when conf.anonymous=nil.

This can be merged as a hotfix so it can land in a minor release, and reverted back in the next major since #2313 already takes care of it.

Full changelog

  • Fixes a bug that triggered 500 errors when an invalid credential is being sent.

@subnetmarco subnetmarco requested a review from Tieske May 9, 2017 18:08
Copy link
Contributor

@p0pr0ck5 p0pr0ck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; would like another pair of eyes as this touches master. @Tieske?

@Tieske
Copy link
Member

Tieske commented May 10, 2017

@thefosk please do open an issue to keep track of reverting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants