Http logging #251
Merged
Http logging #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated statics_spec.lua with new plugin
added test cases updated test case
|
Changes Unknown when pulling af31b0e on http-logging into * on master*. |
| end | ||
|
|
||
| function _M.execute(conf) | ||
| local ok, err = ngx.timer.at(0, log, conf, ngx.ctx.log_message) |
There was a problem hiding this comment.
What is the benefit of putting this into a timer?
There was a problem hiding this comment.
@thibaultcha you don't have access to the cosocket API into the log_by_lua handler, that's why a timer is needed.
|
👍 |
|
🎉 |
|
Yay |
Closed
|
Without squashing? |
ctranxuan
pushed a commit
to streamdataio/kong
that referenced
this pull request
Aug 25, 2015
Http logging
hutchic
pushed a commit
that referenced
this pull request
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.