Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(c*) pass lua_trusted_ssl_cert to lua-cassandra #2531

Merged
merged 2 commits into from May 19, 2017

Conversation

thibaultcha
Copy link
Member

Set LuaSocket's cafile option when we are in a context that does not
support cosockets.

Fix #2528
See thibaultcha/lua-cassandra#95

@p0pr0ck5
Copy link
Contributor

Does this need merge review now, or are we waiting on the upstream dependency?

Set LuaSocket's `cafile` option when we are in a context that does not
support cosockets.

Fix #2528
See thibaultcha/lua-cassandra#95
@thibaultcha thibaultcha force-pushed the fix/cassandra-pass-cafile-option branch from 6192e26 to ac6e779 Compare May 17, 2017 20:26
@thibaultcha
Copy link
Member Author

@p0pr0ck5 I have released lua-cassandra 1.2.2, feel free to give this a review now, there is not much material though.

Copy link
Contributor

@p0pr0ck5 p0pr0ck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@p0pr0ck5 p0pr0ck5 added pr/ready (but hold merge) No more concerns, but do not merge yet (probably a conflict of interest with another PR or release) and removed pr/status/please review labels May 17, 2017
@thibaultcha thibaultcha modified the milestone: 0.10.3 May 19, 2017
@thibaultcha thibaultcha merged commit 2b2ebf2 into master May 19, 2017
@thibaultcha thibaultcha deleted the fix/cassandra-pass-cafile-option branch May 19, 2017 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/ready (but hold merge) No more concerns, but do not merge yet (probably a conflict of interest with another PR or release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants