feat(admin) remove DB counters in favor of a connection test #2567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
commented
May 26, 2017
| assert.is_number(json.server.connections_writing) | ||
| assert.is_number(json.server.connections_waiting) | ||
| assert.is_number(json.server.total_requests) | ||
| assert.True(json.database.reachable) |
There was a problem hiding this comment.
style: assert.is_true()
thibaultcha
force-pushed
the
fix/status-db-connection
branch
from
716e4fb to
a564e48
Compare
|
Ping @shashiranjan84 @p0pr0ck5 @thefosk |
|
@thibaultcha LGTM |
p0pr0ck5
approved these changes
May 30, 2017
| it("obfuscates sensitive settings from the configuration", function() | ||
|
|
||
| it("database.reachable is `true` when DB connection is healthy", function() | ||
| -- In this test, we know our DB is reachable because it must be |
There was a problem hiding this comment.
not a blocker for this PR, but could we simply mock out the dao's reachable function to test this?
There was a problem hiding this comment.
Possibly, although those are "integration" tests, and supposed to be through-to-through. Mocking it is still slightly better, but won't test the reachable method properly. Also, we don't have a process to inject stubs into a running Kong started by the integration tests... 🤔
|
Change added to the wiki's Changelog as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement proposal for #2554. As discussed, the point of this change is to provide a connection test to the database, and not to evaluate its health. Following this logic, this patch is more aligned with the intended goal.
cc @shashiranjan84 @p0pr0ck5 @thefosk