fix(oauth2) body params creds: require both client_id and client_secret #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes POST /oauth2/token request client credentials checking when having: * `client_id:client_secret` passed via the authorization header; * and `client_id` passed as a request body parameter. To retrieve client credentials from the body parameters, both `client_id` and `client_secret` must be present. Fix Kong#2446
p0pr0ck5
reviewed
Jun 1, 2017
There was a problem hiding this comment.
LGTM, would like a second pair of eyes here. @thefosk or @thibaultcha ?
| } | ||
| }) | ||
| local body = assert.res_status(200, res) | ||
| assert.is_table(ngx.re.match(body, [[^\{"token_type":"bearer","access_token":"[\w]{32,32}","expires_in":5\}$]])) |
There was a problem hiding this comment.
oof, these tests are in a really poor form. we should be decoding the returned JSON body and examining each element we care about, not presuming some details about the form of the encoded payload. this isnt a blocker for this review, since it looks like a copypasta from previous commits, more of a note that we should clean up this test in the future :)
subnetmarco
approved these changes
Jun 6, 2017
|
Nice, thanks @cedum for the patch! I believe this should be opened against master though. |
|
Manually merged to master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes POST /oauth2/token request client credentials checking when having:
client_id:client_secretpassed via the authorization header;client_idpassed as a request body parameter.To retrieve client credentials from the body parameters, both
client_idandclient_secretmust be present.Full changelog
spec/03-plugins/26-oauth2/03-access_spec.luaIssues resolved
Fix #2446