fix(proxy) set http_if_terminated false by default #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assume a (very mildly) more agressive posture by disabling interpretation of the X-Forwarded-Proto header in HTTPS-only APIs by default when the client sent a plaintext connection.
|
LGTM @p0pr0ck5 |
shashiranjan84
approved these changes
Jun 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Assume a (very mildly) more agressive posture by disabling interpretation of the X-Forwarded-Proto header in HTTPS-only APIs by default when the client sent a plaintext connection. This does not improve any functional posturing in the analysis of plaintext connections, but it does require that operators explicitly set this value (and thus assumedly understand the current implications of such a configuration)
Full changelog
http_if_terminatedAPI schema member to false by default.Issues resolved
Fix #2583