Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core) explicitly set kong env as user read only #2611

Merged
merged 1 commit into from
Jun 8, 2017

Conversation

p0pr0ck5
Copy link
Contributor

@p0pr0ck5 p0pr0ck5 commented Jun 8, 2017

Summary

Because Kong automatically (re)creates this file, we should be define a more restrictive permissions set. Note this is related specifically to the Kong environment file, not the kong.conf user-defined config file (control of which is the responsibility of the system administrator).

Full changelog

  • Set user read-write, group read, and other none permissions on .kong_env

Issues resolved

Addresses some concerns in #1806

Copy link
Member

@thibaultcha thibaultcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thibaultcha thibaultcha merged commit 9952498 into master Jun 8, 2017
@thibaultcha thibaultcha deleted the fix/env_perms branch June 8, 2017 22:09
@thibaultcha
Copy link
Member

Merged with the following commit message:

feat(cli) explicitly set kong env as user read-only

This is nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants