feat(admin) add /consumers/:id/plugins routes #2714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kikito
force-pushed
the
feat/plugins-by-consumer
branch
from
835b571 to
61fefe0
Compare
kikito
force-pushed
the
feat/plugins-by-consumer
branch
3 times, most recently
from
2de4a1b to
aab58f5
Compare
kikito
changed the title
kikito
force-pushed
the
feat/plugins-by-consumer
branch
from
aab58f5 to
d47d1a5
Compare
kikito
changed the title
kikito
force-pushed
the
feat/plugins-by-consumer
branch
from
d47d1a5 to
0f1f81f
Compare
Tieske
approved these changes
Jul 26, 2017
| fields = { | ||
| value = { typ = "string" } | ||
| value = { typ = "string" }, | ||
| extra = { typ = "string", default = "extra" } |
There was a problem hiding this comment.
minor: please use a trailing comma here, so future diffs will be easier (if the existing line would have had a trailing comma, this diff would have been only 1 line, instead of 3 now)
kikito
force-pushed
the
feat/plugins-by-consumer
branch
from
0f1f81f to
1fffd6e
Compare
thibaultcha
reviewed
Jul 26, 2017
| }) | ||
| assert.res_status(204, res) | ||
| end) | ||
| describe("errors #focus", function() |
There was a problem hiding this comment.
Is the #focus label only for debugging purposes?
kong/api/routes/consumers.lua
Outdated
| crud.find_consumer_by_username_or_id(self, dao_factory, helpers) | ||
| crud.find_plugin_by_filter(self, dao_factory, { | ||
| consumer_id = self.consumer.id, | ||
| id = self.params.id |
There was a problem hiding this comment.
style: such tables could use a trailing comma, as documented in our style guide, to reduce the diff size of future changes applied here.
kikito
force-pushed
the
feat/plugins-by-consumer
branch
from
1fffd6e to
07d12b3
Compare
thibaultcha
approved these changes
Jul 26, 2017
thibaultcha
added
pr/ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds CRUD routes for plugins scoped by consumers to the admin API:
/consumers/:username_or_id/plugins//consumers/:username_or_id/plugins/idThis PR needs #2726 to be merged before it, otherwise the api route tests will fail.
Issues resolved
Closes #2336