refactor(balancer) drop the orderlist property #2748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tieske
force-pushed
the
refactor/drop-order-list
branch
3 times, most recently
from
b074f58
to
8bd3b3b
Compare
thibaultcha
requested changes
Jul 31, 2017
kong/kong.lua
Outdated
| @@ -308,6 +308,7 @@ function Kong.balancer() | |||
| current_try.port = addr.port | |||
|
|
|||
| -- set the targets as resolved | |||
| ngx.log(ngx.DEBUG, "setting address (try ", addr.try_count, "): ",addr.ip,":",addr.port) | |||
There was a problem hiding this comment.
perf: on this hot code path, let's cache ngx.log and ngx.DEBUG which imply global accesses.
style: it seems like we are going over the 80 chars limit and missing a few spaces for readability. Let's use the following form instead:
ngx.log(ngx.DEBUG, "setting address (try ", addr.try_count, "): ",
addr.ip, ":", addr.port)(with globals caching ofc)
| @@ -167,7 +186,7 @@ dao_helpers.for_each_dao(function(kong_config) | |||
| assert.are.equal(requests/2, count1) | |||
| assert.are.equal(requests/2, count2) | |||
| end) | |||
| it("adding a target", function() | |||
| it("adding a target #only", function() | |||
thibaultcha
added
pr/ready (but hold merge)
Tieske
force-pushed
the
refactor/drop-order-list
branch
from
8bd3b3b
to
714adeb
Compare
Tieske
force-pushed
the
refactor/drop-order-list
branch
2 times, most recently
from
92b67fa
to
90466c6
Compare
Tieske
force-pushed
the
refactor/drop-order-list
branch
from
90466c6
to
6e85b52
Compare
thibaultcha
reviewed
Sep 8, 2017
kong-0.11.0-0.rockspec
Outdated
| @@ -27,7 +27,7 @@ dependencies = { | |||
| "luacrypto == 0.3.2", | |||
| "luasyslog == 1.0.0", | |||
| "lua_pack == 1.0.5", | |||
| "lua-resty-dns-client == 0.6.0", | |||
| "lua-resty-dns-client == 0.6.1", | |||
There was a problem hiding this comment.
Should we bump this to 0.6.2 now? Considering master is already there.
Tieske
force-pushed
the
refactor/drop-order-list
branch
from
6e85b52
to
bb207f6
Compare
Tieske
added a commit
to Kong/docs.konghq.com
that referenced
this pull request
Sep 11, 2017
thibaultcha
pushed a commit
to Kong/docs.konghq.com
that referenced
this pull request
Dec 18, 2017
thibaultcha
pushed a commit
to Kong/docs.konghq.com
that referenced
this pull request
Jan 12, 2018
thibaultcha
pushed a commit
to Kong/docs.konghq.com
that referenced
this pull request
Jan 16, 2018
thibaultcha
pushed a commit
to Kong/docs.konghq.com
that referenced
this pull request
Jan 16, 2018
thibaultcha
pushed a commit
that referenced
this pull request
Jan 16, 2018
This removes the `orderlist` property from the balancer entity. Due to a different implementation in the dns library, it is no longer required. from #2748
thibaultcha
pushed a commit
that referenced
this pull request
Jan 19, 2018
This removes the `orderlist` property from the balancer entity. Due to a different implementation in the dns library, it is no longer required. from #2748
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the orderlist property from the balancer entity. Due to a different implementation in the dns library, it is no longer required.
Reason:
Because multiple Kong nodes need the exact same ring-balancer, the orderlist was used to make sure they all used the same random data to set up the balancer.
This has now been replaced by using a separate randomizer in the dns library, which always will be seeded again, and with the same seed. This causes the exact same random set of numbers to be generated. This works because there is no need for uniqueness, there is only need for distribution of the data.