feat(jwt) add endpoint to list all JWTs #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
requested changes
Nov 18, 2017
There was a problem hiding this comment.
Awesome, thank you! I think a better naming of the path parameter is the only missing piece of the puzzle. Requesting this only change and we should be good to go here!
BTW, we are very eager to release this as part of our upcoming 0.11.2 release! Thanks again
kong/plugins/jwt/api.lua
Outdated
| crud.paginated_set(self, dao_factory.jwt_secrets) | ||
| end | ||
| }, | ||
| ["/jwts/:credential_key_or_id/consumer"] = { |
There was a problem hiding this comment.
Would jwt_key_or_id be a better name here? The JWT and it being a credential from the point of view of the Kong data model might not be obvious enough at first sight.
There was a problem hiding this comment.
Makes sense, will push it right away!
There was a problem hiding this comment.
@thibaultcha Line 23 in the same file. Should I change those to keep it consistent?
thibaultcha
added
pr/changes requested
* `/jwts/` to paginate through all JWT credentials * `/jwts/:credential_key_or_id/consumer` to retrieve the Consumer associated with a credential
thibaultcha
approved these changes
Nov 18, 2017
|
Merged, thank you for your contribution! |
hbagdi
added a commit
to hbagdi/getkong.org
that referenced
this pull request
Nov 22, 2017
Two new endpoints have been added to the JWT plugin: * `/jwts/` to paginate through all JWT credentials * `/jwts/:jwt_key_or_id/consumer` to retrieve the Consumer associated with a JWT See Kong/kong#3003
thibaultcha
pushed a commit
to Kong/docs.konghq.com
that referenced
this pull request
Nov 23, 2017
Two new endpoints have been added to the JWT plugin: * `/jwts/` to paginate through all JWT credentials * `/jwts/:jwt_key_or_id/consumer` to retrieve the Consumer associated with a JWT See: Kong/kong#3003 From: #556 Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>
thibaultcha
pushed a commit
to Kong/docs.konghq.com
that referenced
this pull request
Nov 29, 2017
Two new endpoints have been added to the JWT plugin: * `/jwts/` to paginate through all JWT credentials * `/jwts/:jwt_key_or_id/consumer` to retrieve the Consumer associated with a JWT See: Kong/kong#3003 From: #556 Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/jwts/to paginate through all jwt credentials/jwts/:jwt_key_or_id/consumerto retrieve the Consumerassociated with a credential
Similar to #2998 #2955