Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conf-loader) add format check for admin_listen_ssl string #3031

Merged
merged 1 commit into from
Nov 17, 2017

Conversation

nijikokun
Copy link
Contributor

@nijikokun nijikokun commented Nov 16, 2017

Summary

Adds a listen address check in conf_loader.lua for the admin_listen_ssl configuration string to enhance error reporting when a Kong node is misconfigured.

@p0pr0ck5
Copy link
Contributor

LGTM!

Copy link
Member

@thibaultcha thibaultcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an oversight from #1706. Looks great, thanks!

@thibaultcha thibaultcha merged commit 4fb744c into master Nov 17, 2017
@thibaultcha thibaultcha deleted the fix/conf-loader branch November 17, 2017 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants