hotfix(*) credentials endpoints test suites with Cassandra #3051
Conversation
The recent commits adding endpoints to manipulate the credentials of authentication plugins had test cases that were flawed when running with Cassandra. With Cassandra, the `offset` query argument must be URL-encoded, and the `offset` parameter in the Admin API response will also be present in the response for the last page.
|
@hbagdi Would you mind reviewing this change? |
There was a problem hiding this comment.
I just tested this.
Like you said, the last page still returns an offset and the next URI which return an empty data with no offset.
A better test would be to check if an offset is present, and then GET it to make sure that the page is empty.
If there exist elaborative test cases for testing the pagination logic in other modules, then we could skip.
I can help add a patch to this PR. Let mae know.
Also, I'm wondering why the CI tests passed then.. since, we don't mock Cassandra.
The pagination feature is tested in other locations, this present test is more to ensure that 2 subsequent pages are indeed different.
Unfortunately as of today, all of our tests do not run on both databases yet. This has already changed in current WIP branches we will be releasing soon. Sorry about that! |
thibaultcha
deleted the
hotfix/credentials-endpoints-tests-with-cassandra
branch
The recent commits adding endpoints to manipulate the credentials of
authentication plugins had test cases that were flawed when running with
Cassandra.
With Cassandra, the
offsetquery argument must be URL-encoded, and theoffsetparameter in the Admin API response will also be present in theresponse for the last page.