hotfix(log-serializer) avoid redundant request.request_* properties
#3098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reflecting back on #2445, the chosen names feel very redundant when accessed from a queryable interface. The same way, `upstream_uri` seems to have been wrongly added under the `request` scope, where it doesn't belong. This solution has the benefit of being less breaking as well. (Only one field gets renamed).
thibaultcha
added a commit
that referenced
this pull request
Jan 16, 2018
Reflecting back on #2445, the chosen names feel very redundant when accessed from a queryable interface. The same way, `upstream_uri` seems to have been wrongly added under the `request` scope, where it doesn't belong. This solution has the benefit of being less breaking as well. (Only one field gets renamed). From #3098
thibaultcha
added a commit
that referenced
this pull request
Jan 19, 2018
Reflecting back on #2445, the chosen names feel very redundant when accessed from a queryable interface. The same way, `upstream_uri` seems to have been wrongly added under the `request` scope, where it doesn't belong. This solution has the benefit of being less breaking as well. (Only one field gets renamed). From #3098
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflecting back on #2445, the chosen names feel very redundant when
accessed from a queryable interface. The same way,
upstream_uriseemsto have been wrongly added under the
requestscope, where it doesn'tbelong.
This solution has the benefit of being less breaking as well. (Only one
field gets renamed).