feat(reports) custom immutable items #3180
Conversation
There was a problem hiding this comment.
Worried about the missing v ~= nil condition, and a little bit about missing tests (there are unit tests for the phone home buffer in phone_home_spec.lua :)
kong/core/reports.lua
Outdated
| end | ||
|
|
||
| return v | ||
| end |
There was a problem hiding this comment.
style: before merging this, will you update this so we respect the 2 line jumps rule around this function? Thanks!
kong/core/reports.lua
Outdated
| @@ -181,6 +185,15 @@ local function add_ping_value(k, v) | |||
| end | |||
|
|
|||
|
|
|||
| local function add_immutable_value(k, v) | |||
| v = get_report_value(v) | |||
| if v then | |||
There was a problem hiding this comment.
This needs to be if v ~= nil, otherwise we don't respect the above behavior of reports, and we could end up missing some values when they are false.
kong/core/reports.lua
Outdated
| v = get_report_value(v) | ||
| if v then | ||
| _buffer[#_buffer + 1] = k .. "=" .. tostring(v) | ||
| _buffer_immutable_idx = _buffer_immutable_idx + 1 |
There was a problem hiding this comment.
minor: we could do this increment prior to the insertion and save the #_buffer + 1, but not a blocker.
kong/core/reports.lua
Outdated
| v = json | ||
| end | ||
|
|
||
| return v |
There was a problem hiding this comment.
minor: we could do return v ~= nil and tostring(v) or nil here, and provide a safer API (both appends to the buffer would not have to do the tostring() themselves anymore, nor would any future code change), but not a blocker.
Add function to insert custom items in the immutable portion of the report buffer.
gszr
force-pushed
the
feat/reports-custom-immutable-items
branch
from
5fdea6e to
288a099
Compare
Summary
Add function to insert custom items in the immutable
portion of the report buffer.