fix(oauth2) send 400 on invalid scope string #3206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gman98ish
force-pushed
the
master
branch
3 times, most recently
from
78c0741 to
2a72266
Compare
If you create an oauth2 token, and pass something other than a string, you get a 500 error. This updates the retrieve_scopes method to perform a type check and return a 400 if it isn't a string * return 400 when an invalid scope string is given
bungle
added
pr/ready
thibaultcha
reviewed
Mar 27, 2018
| @@ -116,6 +116,11 @@ end | |||
| local function retrieve_scopes(parameters, conf) | |||
| local scope = parameters[SCOPE] | |||
| local scopes = {} | |||
|
|
|||
| if scope and type(scope) ~= "string" then | |||
| return false, {[ERROR] = "invalid_scope", error_description = "scope must be a string"} | |||
There was a problem hiding this comment.
style: we use 2 spaces indentation across this codebase :)
There was a problem hiding this comment.
we should also probably move this branch under the below one
thibaultcha
pushed a commit
that referenced
this pull request
Mar 28, 2018
If you create an oauth2 token and pass something other than a string, you get a 500 error. This updates the retrieve_scopes method to perform a type check and return HTTP 400 if it isn't a string. * return 400 when an invalid scope type is given Fix #3205 From #3206 Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>
|
Manually merged with minor edits, thank you for the patch! |
kikito
pushed a commit
to kikito/kong
that referenced
this pull request
Apr 10, 2018
If you create an oauth2 token and pass something other than a string, you get a 500 error. This updates the retrieve_scopes method to perform a type check and return HTTP 400 if it isn't a string. * return 400 when an invalid scope type is given Fix Kong#3205 From Kong#3206 Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If you create an oauth2 token, and pass a scope as something other than a
string, you get a 500 error. This updates the retrieve_scopes
method to perform a type check and return a 400 if it isn't a
string
Full changelog
Issues resolved
Fix #3205