Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(basic-auth-empty-password) allow empty password #3243

Merged

Conversation

zhouzhuojie
Copy link
Contributor

@zhouzhuojie zhouzhuojie commented Feb 21, 2018

Summary

Story: I'm trying to migrate our current API to kong, and we have to support basic-auth with empty passwords, thus I opened this pr.

I think this is not a breaking change, and it's based on the master branch instead of the next branch.

Related to empty password basic auth

Full changelog

  • Add empty password support for basic-auth

Copy link
Contributor

@hishamhm hishamhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thibaultcha thibaultcha added the pr/ready (but hold merge) No more concerns, but do not merge yet (probably a conflict of interest with another PR or release) label Feb 23, 2018
@thibaultcha thibaultcha merged commit 037c719 into Kong:master Mar 13, 2018
@thibaultcha
Copy link
Member

@zhouzhuojie Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/ready (but hold merge) No more concerns, but do not merge yet (probably a conflict of interest with another PR or release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants