fix(balancer) update default size from 100 to 10000 #3296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we really go with 64k as a default? It does have a noticeable (even if now smaller) memory impact. I wouldn't imagine upstreams with 655 targets to be a common scenario, but there will br lots of upstreams with a low number of targets out there (or even 1 if the goal is to use healthchecks only). Isn't, say, 10000 more than enough for a default value? |
Tieske
force-pushed
the
fix/balancer-size
branch
from
8427fde to
3679d98
Compare
Tieske
changed the title
|
updated to 10k slots |
Tieske
force-pushed
the
fix/balancer-size
branch
from
3679d98 to
01941cb
Compare
The original size was way to low to guarantee proper random distribution beyond 3-4 targets. The recommended size is 100 slots per target. The new default covers up to 100 targets. The approximate footprint per upstream: - 65535 slots, 100 targets: 1.6MB - 10000 slots, 100 targets: 375kB This fix should have been included in the latest update of the DNS library dependency. Related #3220
Tieske
force-pushed
the
fix/balancer-size
branch
from
01941cb to
93d28a6
Compare
thibaultcha
added
pr/ready
thibaultcha
pushed a commit
that referenced
this pull request
Mar 20, 2018
The original size was way to low to guarantee proper random distribution beyond 3-4 targets. The recommended size is 100 slots per target. The new default covers up to 100 targets. The approximate footprint per Upstream: - 65535 slots, 100 targets: 1.6MB - 10000 slots, 100 targets: 375kB This fix should have been included in the latest update of the DNS library dependency. Related #3220 From #3296
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the default balancer size from 100 to 65535 (max size). The original size is to low as the advice is 100 slots for each target.
This should have been included in #3220 since that implemented the performance (speed and footprint) improvement for the balancer to enable the new size default.
Related #3220