Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schemas) check upper bound on healthcheck time values #3306

Merged
merged 1 commit into from Mar 16, 2018

Conversation

hishamhm
Copy link
Contributor

Check for the upper bound of all timeout and interval fields in the health check configuration.

Check for the upper bound of all `timeout` and `interval`
fields in the health check configuration.
Copy link
Contributor

@hutchic hutchic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't run but the tests look good so I presume the code is as well 👍

@hishamhm hishamhm merged commit d6f7904 into master Mar 16, 2018
@thibaultcha thibaultcha deleted the fix/healthcheck-schema-upper-bound branch March 20, 2018 00:25
thibaultcha pushed a commit that referenced this pull request Mar 20, 2018
Check for the upper bound of all `timeout` and `interval`
fields in the health check configuration.
hishamhm added a commit that referenced this pull request Mar 20, 2018
Check for the upper bound of all `timeout` and `interval`
fields in the health check configuration.
hishamhm added a commit that referenced this pull request Mar 21, 2018
Check for the upper bound of all `timeout` and `interval`
fields in the health check configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants