release: 0.13.0 #3318
Closed
release: 0.13.0 #3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for the upper bound of all `timeout` and `interval` fields in the health check configuration.
hishamhm
force-pushed
the
release/0.13.0
branch
from
a16537c
to
3fcb11f
Compare
@thibaultcha fixed! |
In the upstream event handler, `create_balancer` was being called with the object received via the event, which contains "id" and "name" only, and not the entire entity table containing the rest of the upstream fields. This caused it create a healthchecker with an empty configuration (ignoring the user's configuration), which then fell back into the lua-resty-healthcheck defaults. This fix obtains the proper entity object from the id and passes it to `create_balancer`. A regression test is included, which spawns two Kong instances and reproduces the error scenario described by @mengskysama. Fixes #3304 From #3319
The original size was way to low to guarantee proper random distribution beyond 3-4 targets. The recommended size is 100 slots per target. The new default covers up to 100 targets. The approximate footprint per Upstream: - 65535 slots, 100 targets: 1.6MB - 10000 slots, 100 targets: 375kB This fix should have been included in the latest update of the DNS library dependency. Related #3220 From #3296
thibaultcha
force-pushed
the
release/0.13.0
branch
2 times, most recently
from
dabb325
to
83d0a69
Compare
|
For now, waiting on #3324 for the CI to pass on this branch. |
hishamhm
force-pushed
the
release/0.13.0
branch
from
a2f2dd3
to
83d0a69
Compare
thibaultcha
force-pushed
the
release/0.13.0
branch
9 times, most recently
from
0fceacb
to
1ebbe44
Compare
thibaultcha
force-pushed
the
release/0.13.0
branch
from
1ebbe44
to
e36e7bd
Compare
thibaultcha
force-pushed
the
release/0.13.0
branch
from
e36e7bd
to
cff0bae
Compare
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge
TODO:
A few hotfixes cherry-picked from
mastersince 0.13.0rc2: 0.13.0rc2...release/0.13.0Rebase on top of next before merging into next.