fix(balancer) use correct upstream object in event handler #3319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the upstream event handler, `create_balancer` was being called with the object received via the event, which contains "id" and "name" only, and not the entire entity table containing the rest of the upstream fields. This caused it create a healthchecker with an empty configuration (ignoring the user's configuration), which then fell back into the lua-resty-healthcheck defaults. This fix obtains the proper entity object from the id and passes it to `create_balancer`. A regression test is included, which spawns two Kong instances and reproduces the error scenario described by @mengskysama. Fixes #3304.
thibaultcha
pushed a commit
that referenced
this pull request
Mar 20, 2018
In the upstream event handler, `create_balancer` was being called with the object received via the event, which contains "id" and "name" only, and not the entire entity table containing the rest of the upstream fields. This caused it create a healthchecker with an empty configuration (ignoring the user's configuration), which then fell back into the lua-resty-healthcheck defaults. This fix obtains the proper entity object from the id and passes it to `create_balancer`. A regression test is included, which spawns two Kong instances and reproduces the error scenario described by @mengskysama. Fixes #3304 From #3319
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the upstream event handler,
create_balancerwas being called with the object received via the event, which contains "id" and "name" only, and not the entire entity table containing the rest of the upstream fields. This caused it create a healthchecker with an empty configuration (ignoring the user's configuration), which then fell back into the lua-resty-healthcheck defaults.This fix obtains the proper entity object from the id and passes it to
create_balancer.A regression test is included, which spawns two Kong instances and reproduces the error scenario described by @mengskysama.
This commit is against
master, but can be cherry-picked againstnextwith no conflicts.Fixes #3304.