Hmac auth body validation #3347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mvanholsteijn thanks for PR, would you please rebase before we start reviewing ? |
|
@shashiranjan84 Do you have any idea on when this PR might be reviewed? |
kong/plugins/hmac-auth/access.lua
Outdated
| if not body then | ||
| return false | ||
| -- if no body, calculate sha-256 over 0 bytes | ||
| body = '' | ||
| end |
There was a problem hiding this comment.
you can drop this check and just do
sha256:update(body or '')
shashiranjan84
added
pr/ready
|
@mvanholsteijn would you please also update the doc, https://github.com/Kong/getkong.org/blob/master/app/plugins/hmac-authentication.md? |
shashiranjan84
added
pending author feedback
mvanholsteijn
added a commit
to binxio/getkong.org
that referenced
this pull request
May 13, 2018
mvanholsteijn
added a commit
to binxio/getkong.org
that referenced
this pull request
May 13, 2018
|
@shashiranjan84 I added the documentation to getkong.org... |
shashiranjan84
added
pr/ready
|
Thanks @mvanholsteijn . |
|
@mvanholsteijn Thank you for the patch! If you haven't done so yet, be sure to grab your Contributor T-shirt :) |
thibaultcha
pushed a commit
to Kong/docs.konghq.com
that referenced
this pull request
May 19, 2018
Tieske
pushed a commit
to Kong/docs.konghq.com
that referenced
this pull request
May 28, 2018
thibaultcha
pushed a commit
to Kong/docs.konghq.com
that referenced
this pull request
May 30, 2018
hbagdi
pushed a commit
to Kong/docs.konghq.com
that referenced
this pull request
May 31, 2018
thibaultcha
pushed a commit
to Kong/docs.konghq.com
that referenced
this pull request
Jun 28, 2018
ukiahsmith
pushed a commit
to Kong/docs.konghq.com
that referenced
this pull request
Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes the hmac-auth request validation logic to pass if:
Digestand no bodyDigestfor an empty body and no body.Digestfor the body and a body.This is to make sure that we can put 'digest' in the enforce_headers for all requests.
Full changelog
Issues resolved
Fix #3345
Fix #3346