hotfix(dao) ensure 'init()' errors are prefixed with DB name #3411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression introduced in #3310. If the database is unreachabel when Kong start, it is our policy that the error message be prefixed with `[postgres error]` (in the case of PostgreSQL) to help the user troubleshoot the issue. Prior to this patch, this behavior was changed in #3310, since it introduced a call to `init()` in the CLI. Users would see: ``` $ kong start Error: connection refused ``` Instead of: ``` $ kong start Error: [postgres error] could not retrieve server_version: connection refused ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in #3310.
If the database is unreachabel when Kong start, it is our policy that
the error message be prefixed with
[postgres error](in the case ofPostgreSQL) to help the user troubleshoot the issue.
Prior to this patch, this behavior was changed in #3310, since it
introduced a call to
init()in the CLI. Users would see:Instead of: