feat(admin) implement inferring, endpoint key and put support #3416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kikito
approved these changes
Apr 26, 2018
| it("infers nulls from empty strings, arrays or sets", function() | ||
| assert.equal(ngx.null, infer_value("", { type = "string" })) | ||
| assert.equal(ngx.null, infer_value("", { type = "array" })) | ||
| assert.equal(ngx.null, infer_value("", { type = "set" })) |
There was a problem hiding this comment.
If feels weird that infer_value returns null when it encounters "" for arrays and sets, but not for maps or records (for which it returns "" instead)
@hishamhm, what is your opinion on this?
There was a problem hiding this comment.
"" for maps and records should infer null as well.
bungle
force-pushed
the
feat/admin-infer-and-endpoint-key-and-put
branch
2 times, most recently
from
80d6729 to
2de376b
Compare
bungle
force-pushed
the
feat/admin-infer-and-endpoint-key-and-put
branch
from
2de376b to
de7e0f4
Compare
bungle
added
pr/ready
|
Nice! 👍 |
thibaultcha
added a commit
to Kong/docs.konghq.com
that referenced
this pull request
May 11, 2018
thibaultcha
pushed a commit
to Kong/docs.konghq.com
that referenced
this pull request
May 11, 2018
See Kong/kong#3416 Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>
Tieske
pushed a commit
to Kong/docs.konghq.com
that referenced
this pull request
May 28, 2018
See Kong/kong#3416 Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>
thibaultcha
pushed a commit
to Kong/docs.konghq.com
that referenced
this pull request
May 30, 2018
See Kong/kong#3416 Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>
hbagdi
pushed a commit
to Kong/docs.konghq.com
that referenced
this pull request
May 31, 2018
See Kong/kong#3416 Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>
thibaultcha
pushed a commit
to Kong/docs.konghq.com
that referenced
this pull request
Jun 28, 2018
See Kong/kong#3416 Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>
ukiahsmith
pushed a commit
to Kong/docs.konghq.com
that referenced
this pull request
Jul 2, 2018
See Kong/kong#3416 Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances our new model autogenerated Admin API in several ways:
application/x-www-form-urlencodedthat takes into account information from schemasendpoint_keyparameter in schemas that can be pointed to any unique field (allows us to e.g. autogenerate/consumers/<uuid-or-username>)PUTsupport (by<uuid>or by<schema.endpoint_key>(aka unique)Issues resolved
Fix #3378
It will also close these when the respective entities are moved to new model:
Fix (or make obsolete) #3183
Fix (or make obsolete) #3168